Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deconz SSDP updating Hassio config entry #30153

Merged
merged 1 commit into from Dec 22, 2019
Merged

Fix deconz SSDP updating Hassio config entry #30153

merged 1 commit into from Dec 22, 2019

Conversation

@frenck
Copy link
Member

frenck commented Dec 22, 2019

Description:

Fixes an issue where SSDP is capable of updating a configuration entry that originally was created by a Hass.io discovery.

Furthermore, it addresses a small issue in the logic that updates the entry, so that it actually updates the entry when a port or API key is changed, while the host stayed the same.

Related issue (if applicable): fixes home-assistant/hassio-addons#942

Pull request with documentation for home-assistant.io (if applicable): n/a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Dec 22, 2019

Hey there @Kane610, mind taking a look at this pull request as its been labeled with a integration (deconz) you are listed as a codeowner for? Thanks!

@frenck frenck changed the title Fix deconz SSDP updating Hassio discovery Fix deconz SSDP updating Hassio entry Dec 22, 2019
@frenck frenck changed the title Fix deconz SSDP updating Hassio entry Fix deconz SSDP updating Hassio config entry Dec 22, 2019
Copy link
Member

Kane610 left a comment

Looks good!

if (
entry.data[CONF_HOST] == host
and entry.data[CONF_PORT] == port
and (api_key is None or entry.data[CONF_API_KEY] == api_key)

This comment has been minimized.

Copy link
@Kane610

Kane610 Dec 22, 2019

Member

When would updating the api key happen?

This comment has been minimized.

Copy link
@frenck

frenck Dec 22, 2019

Author Member

Re-install the add-on? Reset the gateway?
It is part of the discovery protocol from Hass.io, so it should handle that properly IMHO.

Dev automation moved this from Needs review to Reviewer approved Dec 22, 2019
@frenck frenck added this to the 0.103.4 milestone Dec 22, 2019
@balloob balloob merged commit d101d44 into dev Dec 22, 2019
11 checks passed
11 checks passed
CI Build #20191222.40 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.48%)
Details
codecov/project 94.49% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Dec 22, 2019
@delete-merged-branch delete-merged-branch bot deleted the frenck-2019-0347 branch Dec 22, 2019
@KKlitgaard

This comment has been minimized.

Copy link

KKlitgaard commented Dec 22, 2019

Awesome Franck!

balloob added a commit that referenced this pull request Dec 22, 2019
@balloob balloob mentioned this pull request Dec 22, 2019
@KKlitgaard

This comment has been minimized.

Copy link

KKlitgaard commented Dec 23, 2019

I'm afraid that the issues still appears after this PR: home-assistant/hassio-addons#942 (comment)

This comment has been minimized.

Copy link
Member Author

frenck commented Dec 23, 2019 — with Octobox

That is correct, this is part of the change, not the full change. The other part will be shipped as an add-on update.

@lock lock bot locked and limited conversation to collaborators Dec 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.