Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix google sync #30524

Merged
merged 1 commit into from Jan 6, 2020
Merged

Fix google sync #30524

merged 1 commit into from Jan 6, 2020

Conversation

@balloob
Copy link
Member

balloob commented Jan 6, 2020

Description:

Fix Google Sync and report state. In #29158 the agent user ID used by Google was incorrectly set to the cloud user ID. This had to be the original username as defined in the cloud connection.

To get sync and report state working again, you need to trigger one time a sync via an external method (either ask Google to sync devices or relink account)

Related issue (if applicable):
fixes #29956
fixes #28894

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Jan 6, 2020

Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with a integration (google_assistant) you are listed as a codeowner for? Thanks!

@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Jan 6, 2020

Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with a integration (cloud) you are listed as a codeowner for? Thanks!

@balloob balloob added this to the 0.103.6 milestone Jan 6, 2020
@balloob balloob merged commit 05374d7 into dev Jan 6, 2020
9 checks passed
9 checks passed
CI Build #20200106.48 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
docs-missing Documentation ok.
Dev automation moved this from Needs review to Done Jan 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the hotfix-google-sync branch Jan 6, 2020
balloob added a commit that referenced this pull request Jan 6, 2020
@balloob balloob mentioned this pull request Jan 6, 2020
@elupus

This comment has been minimized.

Copy link
Contributor

elupus commented Jan 6, 2020

Ah. cloud_user vs cloud.username. crap that I did not spot that. Good that you found it.

@lock lock bot locked and limited conversation to collaborators Jan 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.