Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark hide_entity deprecated in automation integration #30799

Merged
merged 1 commit into from Jan 15, 2020
Merged

Conversation

@frenck
Copy link
Member

frenck commented Jan 15, 2020

Breaking Change:

The hide_entity configuration option on an automation is now deprecated and will be removed in Home Assistant 0.107. With Lovelace now being the standard, this option has become obsolete. Please ensure your automations are not using this option.

Description:

See breaking change 馃槈

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11754

Example entry for configuration.yaml (if applicable):

automation:
  - alias: "Home Automation Gone Wrong"
    hide_entity: true
    trigger:
      platform: state
      entity_id: all
    action:
      service: light.turn_off
      entity_id: all

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Jan 15, 2020

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (automation) you are listed as a codeowner for? Thanks!

@project-bot project-bot bot added this to Needs review in Dev Jan 15, 2020
@frenck frenck mentioned this pull request Jan 15, 2020
2 of 2 tasks complete
@frenck frenck marked this pull request as ready for review Jan 15, 2020
@frenck frenck requested a review from home-assistant/core as a code owner Jan 15, 2020
Dev automation moved this from Needs review to Reviewer approved Jan 15, 2020
@balloob balloob merged commit 1e2c3ca into dev Jan 15, 2020
11 checks passed
11 checks passed
CI Build #20200115.50 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing bb42ff9...aba2291
Details
codecov/project 94.58% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Jan 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the frenck-2020-0086 branch Jan 15, 2020
@lock lock bot locked and limited conversation to collaborators Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.