Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

light.yeelight: catch i/o related exceptions from the backend lib #6952

Merged

Conversation

Projects
None yet
6 participants
@rytilahti
Copy link
Contributor

commented Apr 5, 2017

Description:

Fixes/mitigates problems with #5949 and #6624

Related issue (if applicable): fixes #5949 #6624

Checklist:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.
@mention-bot

This comment has been minimized.

Copy link

commented Apr 5, 2017

@rytilahti, thanks for your PR! By analyzing the history of the files in this pull request, we identified @HydrelioxGitHub, @jjensn and @BillyNate to be potential reviewers.

homeassistant/components/light/yeelight.py Outdated
self._bulb.start_flow(flow)
try:
self._bulb.start_flow(flow)
except yeelight.BulbException as ex:

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Apr 5, 2017

undefined name 'yeelight'

@@ -255,7 +255,8 @@ def set_default(self) -> None:
def set_flash(self, flash) -> None:
"""Activate flash."""
if flash:
from yeelight import RGBTransition, SleepTransition, Flow
from yeelight import (RGBTransition, SleepTransition, Flow,

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Apr 5, 2017

'yeelight.BulbException' imported but unused

This comment has been minimized.

Copy link
@rytilahti

rytilahti Apr 5, 2017

Author Contributor

Fixed by forced push, it was used in the prefixed form below in the code.

@rytilahti rytilahti force-pushed the rytilahti:yeelight_catch_music_mode_exception branch to 8c973ea Apr 5, 2017

@balloob balloob added this to the 0.42 milestone Apr 7, 2017

@balloob balloob merged commit d952a07 into home-assistant:dev Apr 7, 2017

4 checks passed

cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.697%
Details
hound No violations found. Woof!

balloob added a commit that referenced this pull request Apr 8, 2017

@balloob

This comment has been minimized.

Copy link
Member

commented Apr 8, 2017

Cherry-picked into the 0.42 branch

@fabaff fabaff referenced this pull request Apr 8, 2017

Merged

0.42 #6956

@rytilahti rytilahti deleted the rytilahti:yeelight_catch_music_mode_exception branch Apr 8, 2017

@balloob balloob referenced this pull request Apr 21, 2017

Merged

0.43 #7197

@home-assistant home-assistant locked and limited conversation to collaborators Jul 17, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.