Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture and log pip install error output #7200

Merged
merged 1 commit into from Apr 21, 2017

Conversation

Projects
None yet
5 participants
@postlund
Copy link
Contributor

commented Apr 21, 2017

Description:

I've seen lots of people in the forum having problems installing dependencies from time to time. Today we merely get a "failed to install XXX" error which doesn't give any details on why the installation failed. With this change, stderr is caught from pip and logged if an error occurred. This way it's easier to see what actually went wrong.

Simulated failure might look like this:

ERROR:homeassistant.util.package:Unable to install package aiohttp_cors==0.5.21: Could not find a version that satisfies the requirement aiohttp_cors==0.5.21 (from versions: 0.1.0, 0.2.0, 0.3.0, 0.4.0, 0.5.0, 0.5.1, 0.5.2)
No matching distribution found for aiohttp_cors==0.5.21

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.
@mention-bot

This comment has been minimized.

Copy link

commented Apr 21, 2017

@postlund, thanks for your PR! By analyzing the history of the files in this pull request, we identified @capellini, @fabaff and @rmkraus to be potential reviewers.

@pvizeli
Copy link
Member

left a comment

Nice Feature ⚡️

@pvizeli

This comment has been minimized.

Copy link
Member

commented Apr 21, 2017

please fix lints

@postlund

This comment has been minimized.

Copy link
Contributor Author

commented Apr 21, 2017

Will do! Wonder why I didn't get an email about that...

@balloobbot balloobbot added the core label Apr 21, 2017

@postlund postlund force-pushed the postlund:packge_install_verbose branch to 9e297cd Apr 21, 2017

@pvizeli pvizeli merged commit f5dd25c into home-assistant:dev Apr 21, 2017

4 checks passed

cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0003%) to 93.605%
Details
hound No violations found. Woof!

hmn added a commit to hmn/home-assistant-dev that referenced this pull request Apr 22, 2017

Merge branch 'dev' into webostv-update
* dev:
  Issue 6749 updated pylgtv to 0.1.6 to fix thread leak in asyncio loop (home-assistant#7199)
  Fix arwn platform to update hass state when events are received (home-assistant#7202)
  Update ios.py (home-assistant#7160)
  Support xy_color with LIFX lights (home-assistant#7208)
  Capture and log pip install error output (home-assistant#7200)

# Conflicts:
#	homeassistant/components/media_player/webostv.py

@balloob balloob referenced this pull request May 5, 2017

Merged

0.44 #7444

@home-assistant home-assistant locked and limited conversation to collaborators Aug 12, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.