Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor lyft sensor update #7233

Merged
merged 1 commit into from Apr 23, 2017

Conversation

Projects
None yet
5 participants
@armills
Copy link
Contributor

commented Apr 22, 2017

Description:

The original issue I came to fix was an error caused when eta_seconds was present in the dict, but contained the value None. This caused an exception when attempting to divide by 60. This PR is a small refactor that also sets the sensor state to None if it can't be fetched, instead of 0.

@mention-bot

This comment has been minimized.

Copy link

commented Apr 22, 2017

@armills, thanks for your PR! By analyzing the history of the files in this pull request, we identified @drkp to be a potential reviewer.

@drkp

drkp approved these changes Apr 23, 2017

Copy link
Contributor

left a comment

LGTM.

@fabaff

fabaff approved these changes Apr 23, 2017

Copy link
Member

left a comment

Thanks 🐦

@fabaff fabaff merged commit b6a4a0d into home-assistant:dev Apr 23, 2017

4 checks passed

cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.004%) to 93.583%
Details
hound No violations found. Woof!

@armills armills deleted the armills:lyft-none-fix branch Apr 23, 2017

@balloob balloob referenced this pull request May 5, 2017

Merged

0.44 #7444

@home-assistant home-assistant locked and limited conversation to collaborators Aug 12, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.