Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recorder: Check for ENTITY_ID key that contains None value #7287

Merged
merged 1 commit into from Apr 25, 2017

Conversation

Projects
None yet
4 participants
@balloob
Copy link
Member

commented Apr 25, 2017

Description:

Fix a bug reported by @dale3h: Sometimes an event is sent that contains the key entity_id but the value is None. This was tripping the recorder.

Checklist:

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.43.1 milestone Apr 25, 2017

@mention-bot

This comment has been minimized.

Copy link

commented Apr 25, 2017

@balloob, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rhooper, @kellerza and @mjg59 to be potential reviewers.

@dale3h

dale3h approved these changes Apr 25, 2017

Copy link
Member

left a comment

Looks good! 🎃

@dale3h dale3h added the bug label Apr 25, 2017

@balloob balloob merged commit 335362f into dev Apr 25, 2017

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on recorder-none-check at 93.596%
Details
hound No violations found. Woof!

@balloob balloob deleted the recorder-none-check branch Apr 25, 2017

balloob added a commit that referenced this pull request Apr 25, 2017

@balloob balloob referenced this pull request Apr 25, 2017

Merged

0.43.1 #7288

@balloob balloob referenced this pull request May 5, 2017

Merged

0.44 #7444

@home-assistant home-assistant locked and limited conversation to collaborators Aug 12, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.