Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netdisco now returns a dictionary while it used to be a tuple, fixed #7350

Merged
merged 1 commit into from Apr 30, 2017

Conversation

Projects
None yet
6 participants
@JasonCarter80
Copy link
Contributor

commented Apr 28, 2017

Netdisco now returns a dictionary while it used to be a tuple, fixed.

Description:

Related issue (if applicable): fixes #
#7240

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.
@mention-bot

This comment has been minimized.

Copy link

commented Apr 28, 2017

@JasonCarter80, thanks for your PR! By analyzing the history of the files in this pull request, we identified @armills, @bah2830 and @tchellomello to be potential reviewers.

@homeassistant

This comment has been minimized.

Copy link

commented Apr 28, 2017

Hi @JasonCarter80,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@balloob

This comment has been minimized.

Copy link
Member

commented Apr 30, 2017

Not sure how I missed this one, sorry. thanks!

@balloob balloob merged commit 607394a into home-assistant:dev Apr 30, 2017

4 checks passed

cla-bot All contributors have signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.009%) to 93.525%
Details
hound No violations found. Woof!

@balloob balloob referenced this pull request May 5, 2017

Merged

0.44 #7444

@home-assistant home-assistant locked and limited conversation to collaborators Aug 12, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.