Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ecobee and joaoapps join for pypi #7430

Merged
merged 1 commit into from May 4, 2017

Conversation

Projects
None yet
4 participants
@nkgilley
Copy link
Contributor

commented May 3, 2017

Description:

update ecobee and joaoapps join for pypi

Related issue (if applicable): fixes #7069

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.
@homeassistant

This comment has been minimized.

Copy link

commented May 3, 2017

Hi @nkgilley,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@fabaff

fabaff approved these changes May 4, 2017

Copy link
Member

left a comment

Thanks 🐦

@fabaff fabaff merged commit 05a3c46 into home-assistant:dev May 4, 2017

4 checks passed

cla-bot All contributors have signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.004%) to 93.471%
Details
hound No violations found. Woof!

@balloob balloob referenced this pull request May 5, 2017

Merged

0.44 #7444

@home-assistant home-assistant locked and limited conversation to collaborators Aug 12, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.