Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HomeMatic: Fix for broken virtual switches #7439

Merged
merged 1 commit into from May 4, 2017

Conversation

Projects
None yet
4 participants
@danielperna84
Copy link
Contributor

commented May 4, 2017

Description:

In the past it was possible to trigger virtual switches on the HomeMatic hub using a service. This doesn't work anymore because the payload data is being capitalized, whereas the device IDs for HomeMatic are case sensitive, which is relevant for this one particular device type.
This change reverts the upper()'d device ID to how it should be.

@mention-bot

This comment has been minimized.

Copy link

commented May 4, 2017

@danielperna84, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pvizeli and @fabaff to be potential reviewers.

@balloob balloob merged commit ea36c91 into home-assistant:dev May 4, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
cla-bot Everyone involved has signed the CLA
coverage/coveralls Coverage increased (+0.004%) to 93.471%
Details
hound No violations found. Woof!

@balloob balloob referenced this pull request May 5, 2017

Merged

0.44 #7444

@home-assistant home-assistant locked and limited conversation to collaborators Aug 12, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.