Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support lutron serena shades #7565

Merged
merged 2 commits into from May 13, 2017

Conversation

Projects
None yet
4 participants
@gurumitts
Copy link
Contributor

gurumitts commented May 12, 2017

Description:

This PR will add support for the Caseta Serena Shades hardware as a home assistant cover device.
There are no breaking changes.
There is no change to the configuration.

Related issue (if applicable): fixes #na

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2622

Example entry for configuration.yaml (if applicable):

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

gurumitts added some commits May 11, 2017

@mention-bot

This comment has been minimized.

Copy link

mention-bot commented May 12, 2017

@gurumitts, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff and @pvizeli to be potential reviewers.

@balloob
Copy link
Member

balloob left a comment

🐬 nice!

@balloob balloob merged commit 11a3dc2 into home-assistant:dev May 13, 2017

4 checks passed

cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.004%) to 93.529%
Details
hound No violations found. Woof!

@gurumitts gurumitts referenced this pull request May 13, 2017

Closed

Serena Shades support #5

@home-assistant home-assistant locked and limited conversation to collaborators Aug 12, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.