Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync crypto-currency platforms #7906

merged 1 commit into from Jun 5, 2017


None yet
6 participants
Copy link

commented Jun 5, 2017


Align all crypto currency platform:

  • Add attributions and icon
  • Do not call update() in constructor
  • Add option to set name
  • Move constants to
  • Ordering

Pull request in with documentation (if applicable): home-assistant/

Example entry for configuration.yaml (if applicable):

  - platform: blockchain
      - '1BMsHFczb2vY1BMDvFGWgGU8mkWVm5fupp'
      - '183J5pXWqYYsxZ7inTVw9tEpejDXyMFroe'
  - platform: etherscan
    address: '0xfB6916095ca1df60bB79Ce92cE3Ea74c37c5d359AAAAA'
  - platform: bitcoin
      - exchangerate
      - trade_volume_btc
  - platform: coinmarketcap


If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass

This comment has been minimized.

Copy link

commented Jun 5, 2017

@fabaff, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @robbiet480 and @Teagan42 to be potential reviewers.

@fabaff fabaff referenced this pull request Jun 5, 2017


Add name #2767

homeassistant/components/sensor/ Outdated
@@ -4,23 +4,37 @@
For more details about this platform, please refer to the documentation at
import logging

This comment has been minimized.

Copy link

houndci-bot Jun 5, 2017

'logging' imported but unused


This comment has been minimized.

Copy link

commented Jun 5, 2017

@fabaff Thank you!

@fabaff fabaff merged commit f8cfa15 into home-assistant:dev Jun 5, 2017

4 checks passed

cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
coverage/coveralls Coverage increased (+0.0003%) to 93.545%
hound No violations found. Woof!

@fabaff fabaff deleted the fabaff:crypto-currencies branch Jun 5, 2017

@balloob balloob referenced this pull request Jun 16, 2017


0.47 #8055

@home-assistant home-assistant locked and limited conversation to collaborators Sep 4, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.