Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move consts to 'const.py' #7909

Merged
merged 1 commit into from Jun 5, 2017

Conversation

Projects
None yet
3 participants
@fabaff
Copy link
Member

commented Jun 5, 2017

Description:

Move ATTR_TIME and ATTR_DATE to const.py. And set the default interval to 2 minutes to avoid that the users run out of API calls.

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: pvoutput
    system_id: YOUR_SYSTEM_ID
    api_key: YOUR_API_KEY
    scan_interval: 120

Checklist:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass

@fabaff fabaff merged commit f303f6a into home-assistant:dev Jun 5, 2017

4 checks passed

cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0006%) to 93.546%
Details
hound No violations found. Woof!

@fabaff fabaff deleted the fabaff:attr-const branch Jun 5, 2017

@balloob balloob referenced this pull request Jun 16, 2017

Merged

0.47 #8055

@home-assistant home-assistant locked and limited conversation to collaborators Sep 4, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.