New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed openhome metadata issue #7932

Merged
merged 1 commit into from Jun 9, 2017

Conversation

Projects
None yet
7 participants
@bazwilliams
Contributor

bazwilliams commented Jun 6, 2017

Description:

A change in the openhomedevice library now means some metadata might not be present when requesting track information. I forgot to defend against this and as a result when the metadata is not present an key exception is thrown.

This also stops devices from being registered on discovery due to the call of 'update' when adding.

Related issue (if applicable): fixes #7926

Checklist:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jun 6, 2017

@bazwilliams, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob and @fabaff to be potential reviewers.

mention-bot commented Jun 6, 2017

@bazwilliams, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob and @fabaff to be potential reviewers.

Show outdated Hide outdated homeassistant/components/media_player/openhome.py Outdated
Show outdated Hide outdated homeassistant/components/media_player/openhome.py Outdated
@pvizeli

pvizeli requested changes Jun 8, 2017 edited

instead this 2 lines use:

return self._track_information.get('albumArtwork')

Change also the quote to single. Make sure that the update() make a empty dict if no data are available and set that also on init.

@balloob

balloob approved these changes Jun 9, 2017

@balloob balloob added this to the 0.46.1 milestone Jun 9, 2017

@balloob balloob merged commit e4d100d into home-assistant:dev Jun 9, 2017

4 checks passed

cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.544%
Details
hound No violations found. Woof!
@balloob

This comment has been minimized.

Show comment
Hide comment
@balloob

balloob Jun 9, 2017

Member

Cherry-picked for 0.46.1

Member

balloob commented Jun 9, 2017

Cherry-picked for 0.46.1

balloob added a commit that referenced this pull request Jun 9, 2017

@balloob balloob referenced this pull request Jun 9, 2017

Merged

0.46.1 #7968

joshuaja added a commit to joshuaja/home-assistant that referenced this pull request Jun 11, 2017

Merge branch 'dev' of https://github.com/home-assistant/home-assistant
…into dev

* 'dev' of https://github.com/home-assistant/home-assistant: (1081 commits)
  dismiss service for persistent notifications (home-assistant#7996)
  LIFX: add support for setting infrared level (home-assistant#8000)
  LIFX: clean up internal color conversions (home-assistant#7964)
  Upgrade py-cpuinfo to 3.3.0 (home-assistant#7992)
  Bugfixing with version 0.4.4 of denonavr (home-assistant#7995)
  make `last_name` field optional (home-assistant#7988)
  test that all lights turn off when no entity id is given (home-assistant#7981)
  Update eliqonline.py (home-assistant#7977)
  HomeMatic optimizations and code cleanup (home-assistant#7986)
  Nadtcp component (home-assistant#7955)
  New component: Python Script (home-assistant#7950)
  Fix platforms being able to block startup (home-assistant#7970)
  Prevent Roku doing I/O in event loop (home-assistant#7969)
  Prevent Roku doing I/O in event loop (home-assistant#7969)
  Create metoffice.py (home-assistant#7965)
  Create metoffice.py (home-assistant#7965)
  Fixed metadata issue (home-assistant#7932)
  Fixed metadata issue (home-assistant#7932)
  Mqtt cover modifications (home-assistant#7841)
  Fix typos in Wunderground component (Percipitation -> Precipitation) (home-assistant#7901)
  ...

@balloob balloob referenced this pull request Jun 16, 2017

Merged

0.47 #8055

@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.