Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nadtcp component #7955

Merged
merged 10 commits into from Jun 9, 2017

Conversation

Projects
None yet
6 participants
@mwsluis
Copy link
Contributor

commented Jun 8, 2017

This replaces pull request #6882 which may be closed.

@mention-bot

This comment has been minimized.

Copy link

commented Jun 8, 2017

@mwsluis, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @balloob and @rmkraus to be potential reviewers.

def is_volume_muted(self):
"""Boolean if volume is currently muted."""
return self._mute

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jun 8, 2017

blank line at end of file

@armills

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2017

@armills
Copy link
Contributor

left a comment

Hound called out the blank line, and the NAD_tcp name isn't valid. Maybe NadTcp or similar. The convention can be found here.

@armills
Copy link
Contributor

left a comment

Looks good. Thanks for all the great work of getting changes upstream!

One last note here, is can we use the same version of nad_receiver from pip that we're using in the other platform?

CONF_NAME, STATE_OFF, STATE_ON)
import homeassistant.helpers.config_validation as cv

REQUIREMENTS = ['https://github.com/joopert/nad_receiver/archive/'

This comment has been minimized.

This comment has been minimized.

Copy link
@mwsluis

mwsluis Jun 8, 2017

Author Contributor

I just did a quick test and it works with 0.0.5 as expected. I'll commit in a sec.

@armills

armills approved these changes Jun 8, 2017

@armills

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2017

Ah, it looks like @joopert bumped to 0.0.6 just within the last 24 hours. You'll have to follow the instructions here to get up-to-date: https://home-assistant.io/developers/development_catching_up/

#7945

@mwsluis

This comment has been minimized.

Copy link
Contributor Author

commented Jun 8, 2017

I just noticed 😊 Well, this latest commit should do the trick. I hope.

@armills

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2017

@armills armills merged commit 49d6427 into home-assistant:dev Jun 9, 2017

4 checks passed

cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 93.556%
Details
hound No violations found. Woof!
@armills

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2017

Thanks for the PR! 🎉 I know this has been a long time in the making. Appreciate the effort to get it done right!

joshuaja added a commit to joshuaja/home-assistant that referenced this pull request Jun 11, 2017

Merge branch 'dev' of https://github.com/home-assistant/home-assistant
…into dev

* 'dev' of https://github.com/home-assistant/home-assistant: (1081 commits)
  dismiss service for persistent notifications (home-assistant#7996)
  LIFX: add support for setting infrared level (home-assistant#8000)
  LIFX: clean up internal color conversions (home-assistant#7964)
  Upgrade py-cpuinfo to 3.3.0 (home-assistant#7992)
  Bugfixing with version 0.4.4 of denonavr (home-assistant#7995)
  make `last_name` field optional (home-assistant#7988)
  test that all lights turn off when no entity id is given (home-assistant#7981)
  Update eliqonline.py (home-assistant#7977)
  HomeMatic optimizations and code cleanup (home-assistant#7986)
  Nadtcp component (home-assistant#7955)
  New component: Python Script (home-assistant#7950)
  Fix platforms being able to block startup (home-assistant#7970)
  Prevent Roku doing I/O in event loop (home-assistant#7969)
  Prevent Roku doing I/O in event loop (home-assistant#7969)
  Create metoffice.py (home-assistant#7965)
  Create metoffice.py (home-assistant#7965)
  Fixed metadata issue (home-assistant#7932)
  Fixed metadata issue (home-assistant#7932)
  Mqtt cover modifications (home-assistant#7841)
  Fix typos in Wunderground component (Percipitation -> Precipitation) (home-assistant#7901)
  ...

@mwsluis mwsluis deleted the mwsluis:nadtcp-component branch Jun 14, 2017

@balloob balloob referenced this pull request Jun 16, 2017

Merged

0.47 #8055

@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.