New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Met Office Sensor #7965

Merged
merged 1 commit into from Jun 9, 2017

Conversation

Projects
None yet
4 participants
@cyberjacob
Contributor

cyberjacob commented Jun 8, 2017

Description:

Fixes the Met Office sensor issues raised at https://community.home-assistant.io/t/metoffice-integration/15537. No new dependencies or files.

Related issue (if applicable): fixes https://community.home-assistant.io/t/metoffice-integration/15537

Pull request in home-assistant.github.io with documentation (if applicable): N/A, no configuration changes

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.
Create metoffice.py
Fix met office sensor
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jun 8, 2017

@cyberjacob, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jacobtomlinson and @fabaff to be potential reviewers.

mention-bot commented Jun 8, 2017

@cyberjacob, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jacobtomlinson and @fabaff to be potential reviewers.

@balloob

This comment has been minimized.

Show comment
Hide comment
@balloob

balloob Jun 9, 2017

Member

Thanks!

Cherry-picked for 0.46.1

Member

balloob commented Jun 9, 2017

Thanks!

Cherry-picked for 0.46.1

@balloob balloob merged commit 24a1721 into home-assistant:dev Jun 9, 2017

4 checks passed

cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.544%
Details
hound No violations found. Woof!

balloob added a commit that referenced this pull request Jun 9, 2017

Create metoffice.py (#7965)
Fix met office sensor

@balloob balloob referenced this pull request Jun 9, 2017

Merged

0.46.1 #7968

joshuaja added a commit to joshuaja/home-assistant that referenced this pull request Jun 11, 2017

Merge branch 'dev' of https://github.com/home-assistant/home-assistant
…into dev

* 'dev' of https://github.com/home-assistant/home-assistant: (1081 commits)
  dismiss service for persistent notifications (home-assistant#7996)
  LIFX: add support for setting infrared level (home-assistant#8000)
  LIFX: clean up internal color conversions (home-assistant#7964)
  Upgrade py-cpuinfo to 3.3.0 (home-assistant#7992)
  Bugfixing with version 0.4.4 of denonavr (home-assistant#7995)
  make `last_name` field optional (home-assistant#7988)
  test that all lights turn off when no entity id is given (home-assistant#7981)
  Update eliqonline.py (home-assistant#7977)
  HomeMatic optimizations and code cleanup (home-assistant#7986)
  Nadtcp component (home-assistant#7955)
  New component: Python Script (home-assistant#7950)
  Fix platforms being able to block startup (home-assistant#7970)
  Prevent Roku doing I/O in event loop (home-assistant#7969)
  Prevent Roku doing I/O in event loop (home-assistant#7969)
  Create metoffice.py (home-assistant#7965)
  Create metoffice.py (home-assistant#7965)
  Fixed metadata issue (home-assistant#7932)
  Fixed metadata issue (home-assistant#7932)
  Mqtt cover modifications (home-assistant#7841)
  Fix typos in Wunderground component (Percipitation -> Precipitation) (home-assistant#7901)
  ...

@balloob balloob referenced this pull request Jun 16, 2017

Merged

0.47 #8055

@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.