Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Roku doing I/O in event loop #7969

Merged
merged 1 commit into from Jun 9, 2017

Conversation

Projects
None yet
4 participants
@balloob
Copy link
Member

commented Jun 9, 2017

Description:

Roku was doing I/O in the event loop. This prevents it.

Reported by @justinglow at #4210 (comment)

Related issue (if applicable): #4210

@mention-bot

This comment has been minimized.

Copy link

commented Jun 9, 2017

@balloob, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bah2830, @fabaff and @tchellomello to be potential reviewers.

@balloob balloob force-pushed the roku-io-event-loop branch to 8aa0856 Jun 9, 2017

@balloob balloob merged commit a223efb into dev Jun 9, 2017

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
cla-bot Everyone involved has signed the CLA
hound No violations found. Woof!

@balloob balloob added this to the 0.46.1 milestone Jun 9, 2017

balloob added a commit that referenced this pull request Jun 9, 2017

@balloob balloob referenced this pull request Jun 9, 2017

Merged

0.46.1 #7968

joshuaja added a commit to joshuaja/home-assistant that referenced this pull request Jun 11, 2017

Merge branch 'dev' of https://github.com/home-assistant/home-assistant
…into dev

* 'dev' of https://github.com/home-assistant/home-assistant: (1081 commits)
  dismiss service for persistent notifications (home-assistant#7996)
  LIFX: add support for setting infrared level (home-assistant#8000)
  LIFX: clean up internal color conversions (home-assistant#7964)
  Upgrade py-cpuinfo to 3.3.0 (home-assistant#7992)
  Bugfixing with version 0.4.4 of denonavr (home-assistant#7995)
  make `last_name` field optional (home-assistant#7988)
  test that all lights turn off when no entity id is given (home-assistant#7981)
  Update eliqonline.py (home-assistant#7977)
  HomeMatic optimizations and code cleanup (home-assistant#7986)
  Nadtcp component (home-assistant#7955)
  New component: Python Script (home-assistant#7950)
  Fix platforms being able to block startup (home-assistant#7970)
  Prevent Roku doing I/O in event loop (home-assistant#7969)
  Prevent Roku doing I/O in event loop (home-assistant#7969)
  Create metoffice.py (home-assistant#7965)
  Create metoffice.py (home-assistant#7965)
  Fixed metadata issue (home-assistant#7932)
  Fixed metadata issue (home-assistant#7932)
  Mqtt cover modifications (home-assistant#7841)
  Fix typos in Wunderground component (Percipitation -> Precipitation) (home-assistant#7901)
  ...

@balloob balloob referenced this pull request Jun 16, 2017

Merged

0.47 #8055

@lwis lwis deleted the roku-io-event-loop branch Jun 21, 2017

@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.