New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for Shiftr.io #7974

Merged
merged 4 commits into from Jun 17, 2017

Conversation

Projects
None yet
5 participants
@fabaff
Member

fabaff commented Jun 9, 2017

Description:

This component simply make the events from Home Assistant available in the communication infrastructure on shiftr.io. This allows one to share data and see the flows in a realtime graph that visualizes all events happening in a namespace.

shiftr-io

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2827

Example entry for configuration.yaml (if applicable):

shiftr:
  username: 7879cb40
  password: 5e8bh7bebe4c0cc0

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.
@robmarkcole

This comment has been minimized.

Contributor

robmarkcole commented Jun 10, 2017

@fabaff fabaff changed the title from [WIP] Add initial support for Shiftr.io to Add initial support for Shiftr.io Jun 12, 2017

@pvizeli

I don't sure if we should use our internal mqtt server object. They is also connect to dispatcher and that do not check from where the data a are comming. I think that is a bit a security hole.

Maby with a own paho client or hbmqtt we are better and any future change on our internal mqtt server object will not affect shiftr negative?

mqttc = mqtt.Client(client_id, protocol=mqtt.MQTTv311)
mqttc.username_pw_set(username, password=password)
mqttc.connect(SHIFTR_BROKER, port=port, keepalive=keepalive)

This comment has been minimized.

@pvizeli

pvizeli Jun 16, 2017

Member

I think that need inside a yield from hass.async_add_job() to not block the loop.

@fabaff fabaff referenced this pull request Jun 16, 2017

Merged

Add Shiftr.io docs #2827

@fabaff

This comment has been minimized.

Member

fabaff commented Jun 17, 2017

Thanks for the update. The idea was to use the internal MQTT object to be async but I will work that way too.

@fabaff fabaff merged commit 844c814 into home-assistant:dev Jun 17, 2017

4 checks passed

cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.08%) to 93.749%
Details
hound No violations found. Woof!

@fabaff fabaff deleted the fabaff:shiftr branch Jun 17, 2017

@balloob balloob referenced this pull request Jul 1, 2017

Merged

0.48 #8270

@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.