Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the Wind sensor following new release of netatmo-api-python #8030

Merged
merged 2 commits into from Jun 16, 2017

Conversation

Projects
None yet
7 participants
@glpatcern
Copy link
Contributor

commented Jun 14, 2017

Description:

The Wind NetAtmo sensor was unsupported and effectively broken so far.
Essentially, this commit adds a protection when adding incorrect monitored conditions to avoid to fail the entire NetAtmo component. Moreover for consistency reasons all conditions are renamed to lower case.

The real fix comes with python-netatmo-api 0.9.2, merged PR at:
jabesq/netatmo-api-python#5

No user configuration is changed by this patch. I did not run any integration test yet, I guess this will come by the PR itself. Obviously, "it works for me", but I'm available to execute any test as required.

Fixed the Wind sensor following new release of netatmo-api-python
The NetAtmo PR was at:
jabesq/netatmo-api-python#5

Essentially, this commit adds a protection when adding an incorrect
monitored conditions to avoid to fail the entire NetAtmo component,
plus for consistency reasons all conditions are now in lower case.
@homeassistant

This comment has been minimized.

Copy link

commented Jun 14, 2017

Hi @glpatcern,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@mention-bot

This comment has been minimized.

Copy link

commented Jun 14, 2017

@glpatcern, thanks for your PR! By analyzing the history of the files in this pull request, we identified @HydrelioxGitHub, @jabesq and @fabaff to be potential reviewers.

if variable in SENSOR_TYPES.keys():
dev.append(NetAtmoSensor(data, module_name, variable))
else:
_LOGGER.warning("Ignoring unknown var %s for mod %s", \

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jun 14, 2017

the backslash is redundant between brackets

@homeassistant homeassistant added cla-signed and removed cla-needed labels Jun 14, 2017

@balloob balloob changed the base branch from master to dev Jun 15, 2017

@balloob

This comment has been minimized.

Copy link
Member

commented Jun 15, 2017

You deleted the instruction to run script/gen_requirements.py… please do so anyway to get CI to pass.

@glpatcern glpatcern force-pushed the glpatcern:master branch to 4b35b2c Jun 15, 2017

@glpatcern

This comment has been minimized.

Copy link
Contributor Author

commented Jun 15, 2017

Hi Paulus, sure - I thought the other instructions were not relevant but anyway I applied the required changes to hopefully get CI to pass.

@glpatcern

This comment has been minimized.

Copy link
Contributor Author

commented Jun 15, 2017

...which now fails on a different unrelated place, where it was passing before. As far as I can see, the PR is clear, but please advice.

@balloob balloob merged commit 09ca440 into home-assistant:dev Jun 16, 2017

4 checks passed

cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.633%
Details
hound No violations found. Woof!
@balloob

This comment has been minimized.

Copy link
Member

commented Jun 16, 2017

Awesome, thanks 👍

@balloob balloob referenced this pull request Jun 16, 2017

Merged

0.47 #8055

@glpatcern

This comment has been minimized.

Copy link
Contributor Author

commented Jun 16, 2017

You're welcome! Glad to have contributed to this project, and I expect some more contributions in the near future...

@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.