Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update knxip to 0.4 (better handling of reconnects) #8289

Merged
merged 1 commit into from Jul 2, 2017

Conversation

Projects
None yet
4 participants
@open-homeautomation
Copy link
Contributor

commented Jul 2, 2017

Description: Updated knxip library to 0.4

Related issue (if applicable): fixes reconnect problems

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.
@mention-bot

This comment has been minimized.

Copy link

commented Jul 2, 2017

@open-homeautomation, thanks for your PR! By analyzing the history of the files in this pull request, we identified @usul27, @nkgilley and @fabaff to be potential reviewers.

@fabaff

fabaff approved these changes Jul 2, 2017

Copy link
Member

left a comment

Thanks 🐦

@fabaff fabaff merged commit 05ced33 into home-assistant:dev Jul 2, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
cla-bot Everyone involved has signed the CLA
coverage/coveralls Coverage remained the same at 93.596%
Details
hound No violations found. Woof!

@balloob balloob referenced this pull request Jul 13, 2017

Merged

0.49 #8468

@open-homeautomation open-homeautomation deleted the open-homeautomation:knx04 branch Jul 20, 2017

dethpickle added a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017

@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.