Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets spotify media_type to music #8387

Merged
merged 3 commits into from Jul 7, 2017

Conversation

Projects
None yet
6 participants
@Tommatheussen
Copy link
Contributor

commented Jul 7, 2017

Description:

This PR sets the Spotify Media Player to MEDIA_TYPE_MUSIC (always).
Before this change, the spotify component looks like this:
image

After the change, it looks like this:
image

Notice how the component now shows the Artist as well.

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
No new docs needed

Example entry for configuration.yaml (if applicable):

No config changes

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

I'm not sure if the height of the card is dependent on the media type as well.

@mention-bot

This comment has been minimized.

Copy link

commented Jul 7, 2017

@Tommatheussen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @happyleavesaoc, @fabaff and @Teagan42 to be potential reviewers.

@@ -313,3 +313,8 @@ def supported_features(self):
if self._user is not None and self._user['product'] == 'premium':
return SUPPORT_SPOTIFY
return None

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jul 7, 2017

blank line contains whitespace

Tommatheussen and others added some commits Jul 7, 2017

@balloob

balloob approved these changes Jul 7, 2017

@balloob

This comment has been minimized.

Copy link
Member

commented Jul 7, 2017

Thanks! 🐬

@balloob balloob merged commit 233920f into home-assistant:dev Jul 7, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
cla-bot Everyone involved has signed the CLA

@Tommatheussen Tommatheussen deleted the Tommatheussen:patch-3 branch Jul 7, 2017

@balloob balloob referenced this pull request Jul 13, 2017

Merged

0.49 #8468

dethpickle added a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017

Sets spotify media_type to music (home-assistant#8387)
* Sets spotify media_type to music

* Removed whitespace

* Update spotify.py

@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.