Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle the case when a group includes itself. #8398

Merged
merged 2 commits into from Jul 8, 2017

Conversation

Projects
None yet
4 participants
@andrey-git
Copy link
Contributor

commented Jul 7, 2017

Description:

Properly handle the case when a group includes itself.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

andrey-git added some commits Jul 7, 2017

@mention-bot

This comment has been minimized.

Copy link

commented Jul 7, 2017

@andrey-git, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @pvizeli and @fabaff to be potential reviewers.

@balloob

This comment has been minimized.

Copy link
Member

commented Jul 8, 2017

Should we instead try to prevent a group from being added to itself?

(or is there a use case I'm missing)

@andrey-git

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2017

As a general case a group might include itself to show group status.

I use it in customUI because I expand the inner group into badges it contains.

@balloob

This comment has been minimized.

Copy link
Member

commented Jul 8, 2017

Haha, as usual your use case is some crazy hack 😝

@balloob balloob merged commit c5bf4fe into home-assistant:dev Jul 8, 2017

4 checks passed

cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 93.579%
Details
hound No violations found. Woof!

@balloob balloob referenced this pull request Jul 13, 2017

Merged

0.49 #8468

dethpickle added a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017

Properly handle the case when a group includes itself. (home-assistan…
…t#8398)

* Properly handle the case when a group includes itself.

* Fix lint

@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017

@andrey-git andrey-git deleted the andrey-git:group branch Nov 30, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.