New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if /dev/input/by-id exists #8601

Merged
merged 1 commit into from Jul 24, 2017

Conversation

Projects
None yet
5 participants
@schaal
Contributor

schaal commented Jul 22, 2017

Description:

If the input device is not connected when starting hass, keyboard_remote tries to access /dev/input/by-id, which may not exist. This PR adds a check to only access the by-id folder if it exists.

Checklist:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
@homeassistant

This comment has been minimized.

homeassistant commented Jul 22, 2017

Hi @schaal,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@mention-bot

This comment has been minimized.

mention-bot commented Jul 22, 2017

@schaal, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MrMep, @deisi and @fabaff to be potential reviewers.

@homeassistant homeassistant added cla-signed and removed cla-needed labels Jul 22, 2017

@balloob balloob added this to the 0.49.1 milestone Jul 24, 2017

@balloob balloob merged commit 1831a7d into home-assistant:dev Jul 24, 2017

4 checks passed

cla-bot All contributors have signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.641%
Details
hound No violations found. Woof!

balloob added a commit that referenced this pull request Jul 24, 2017

@balloob balloob referenced this pull request Jul 24, 2017

Merged

0.49.1 #8625

@schaal schaal deleted the schaal:check-by-id-path branch Jul 24, 2017

dethpickle added a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017

@home-assistant home-assistant locked and limited conversation to collaborators Dec 11, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.