Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block dependencies that depend on enum34 #8698

Merged
merged 7 commits into from Aug 5, 2017

Conversation

Projects
None yet
4 participants
@balloob
Copy link
Member

commented Jul 29, 2017

Description:

This blocks enum34 from being installed. It is a backport of the Python 3.4 enum module for Python 2.7-3.3. It is never needed for Home Assistant.

When installed in Python 3.6, it will blow up things that depend on enum.

This change will fail any dependency that tries to install enum34. As these dependencies have to depend on enum-compat instead, which will only install enum34 when necessary.

See earlier work done in #8103

As this is very annoying, I'm planning on disabling components/platforms that currently depend on requirements that pull in enum34. Based on the current list that will only be sensor.skybeacon.

Found violating packages with pipdeptree --reverse --packages enum34:

  • libpurecoollink==0.2.0 [requires: enum34>=1.1.6] - PR to fix it: CharlesBlonde/libpurecoollink#10
  • pygatt==3.1.1 [requires: enum34] - PR with fix has gone stale: peplin/pygatt#131 - Used by sensor.skybeacon
  • yeelight==0.3.0 [requires: enum34] - fixed in 0.3.2 so upgraded in this PR

The pygatt and yeelight PRs have been submitted over a month ago and have not gotten any response.

Related issue (if applicable): fixes #7733

@balloob balloob force-pushed the block-enum34 branch from 565ffc8 to 726685e Aug 1, 2017

@balloob balloob force-pushed the block-enum34 branch from 726685e Aug 4, 2017

@balloob balloob force-pushed the block-enum34 branch to e4b2239 Aug 4, 2017

@CharlesBlonde CharlesBlonde referenced this pull request Aug 4, 2017

Merged

Fix Dyson sensors #8826

5 of 5 tasks complete

@balloob balloob force-pushed the block-enum34 branch from e4b2239 to 5d43510 Aug 4, 2017

balloob added some commits Jul 29, 2017

@balloob balloob force-pushed the block-enum34 branch from 5d43510 to c3d7d8a Aug 5, 2017

@balloob balloob merged commit e49b970 into dev Aug 5, 2017

5 checks passed

cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.004%) to 93.762%
Details
hound No violations found. Woof!

@balloob balloob deleted the block-enum34 branch Aug 5, 2017

@fabaff fabaff referenced this pull request Aug 12, 2017

Merged

0.51 #8919

dethpickle added a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017

Block dependencies that depend on enum34 (home-assistant#8698)
* Block dependencies that depend on enum34

* Remove uninstalling enum34

* Update validation script

* Add constraints to tox.ini

* Upgrade yeelight to version that uses enum-compat

* Disable sensor.skybeacon

* Lint
@patrickkeys

This comment has been minimized.

Copy link

commented Dec 9, 2017

Looks like pygatt may now be fixed: https://github.com/peplin/pygatt/blob/master/CHANGELOG.rst. Could the skybeacon component be re-enabled now, or is more work required?

@balloob

This comment has been minimized.

Copy link
Member Author

commented Dec 9, 2017

If a new release of pygatt has been done, you can submit a PR to Home Assistant to uncomment and upgrade the dependency for skybeacon.

@home-assistant home-assistant locked and limited conversation to collaborators Mar 30, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.