New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sensor issue with Google Wifi routers in bridge mode #8710

Merged
merged 2 commits into from Jul 30, 2017

Conversation

Projects
None yet
4 participants
@fronzbot
Contributor

fronzbot commented Jul 30, 2017

Description:

  • Router in bridge mode apparently don't report all of the stats (local IP Address)
  • Re-wrote the data_format function so it's a bit easier to follow and able to log keys that aren't supported by a router in a given mode
  • Changed config so that it properly ignores conditions when not explicitly listed
  • Added tests to check for the above and also to verify we log that a key doesn't exist rather than throwing an exception

Related issue (if applicable): fixes #8705

Checklist:

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.
Fixed issue with routers in bridge mode
- Router in brdige mode apparently don't report all of the stats
- Re-wrote the data_format function so it's a bit easier to follow and able to log keys that aren't supported by a router in a given mode
- Changed config so that it properly ignores conditions when not explicitly listed
- Added tests to check for the above and also to verify we log that a key doesn't exist rather than throwing an exception
@fronzbot

This comment has been minimized.

Contributor

fronzbot commented Jul 30, 2017

@balloob Can this bugfix get added to the next patch milestone?

@fronzbot fronzbot changed the title from Fixed issue with routers in bridge mode to Fixed sensor issue with Google Wifi routers in bridge mode Jul 30, 2017

Mistakenly was calling MONITORED_CONDITIONS in data_format
- Changed to be the actual config values to prevent log error

@balloob balloob added this to the 0.50.2 milestone Jul 30, 2017

@balloob

This comment has been minimized.

Member

balloob commented Jul 30, 2017

Thanks for the quick fix! 🎉 🐬 Will include it in 0.50.2

@balloob balloob merged commit 418a8ba into home-assistant:dev Jul 30, 2017

4 checks passed

cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.003%) to 93.63%
Details
hound No violations found. Woof!

balloob added a commit that referenced this pull request Jul 31, 2017

Fixed sensor issue with Google Wifi routers in bridge mode (#8710)
* Fixed issue with routers in bridge mode

- Router in brdige mode apparently don't report all of the stats
- Re-wrote the data_format function so it's a bit easier to follow and able to log keys that aren't supported by a router in a given mode
- Changed config so that it properly ignores conditions when not explicitly listed
- Added tests to check for the above and also to verify we log that a key doesn't exist rather than throwing an exception

* Mistakenly was calling MONITORED_CONDITIONS in data_format

- Changed to be the actual config values to prevent log error

@balloob balloob referenced this pull request Jul 31, 2017

Merged

0.50.2 #8757

dethpickle added a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017

Fixed sensor issue with Google Wifi routers in bridge mode (home-assi…
…stant#8710)

* Fixed issue with routers in bridge mode

- Router in brdige mode apparently don't report all of the stats
- Re-wrote the data_format function so it's a bit easier to follow and able to log keys that aren't supported by a router in a given mode
- Changed config so that it properly ignores conditions when not explicitly listed
- Added tests to check for the above and also to verify we log that a key doesn't exist rather than throwing an exception

* Mistakenly was calling MONITORED_CONDITIONS in data_format

- Changed to be the actual config values to prevent log error

@home-assistant home-assistant locked and limited conversation to collaborators Dec 11, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.