Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch exception and more (fixes #8724) #8731

Merged
merged 1 commit into from Aug 1, 2017

Conversation

Projects
None yet
4 participants
@fabaff
Copy link
Member

commented Jul 30, 2017

Description:

  • Fix typos
  • Fix available(self)
  • Catch connection error
  • Update ordering

Related issue (if applicable): fixes #8724

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: google_wifi

Checklist:

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.
@fronzbot

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2017

This was already fixed with #8710

@pvizeli pvizeli added the cla-recheck label Aug 1, 2017

@homeassistant homeassistant added cla-signed and removed cla-recheck labels Aug 1, 2017

@pvizeli pvizeli added this to the 0.50.3 milestone Aug 1, 2017

@pvizeli

pvizeli approved these changes Aug 1, 2017

@pvizeli pvizeli merged commit 50cd6c9 into dev Aug 1, 2017

5 checks passed

cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.0003%) to 93.672%
Details
hound No violations found. Woof!
@pvizeli

This comment has been minimized.

Copy link
Member

commented Aug 1, 2017

@fronzbot read the PR exaclt and you will see that is not the same ;)

@pvizeli pvizeli deleted the typo-google-wifi branch Aug 1, 2017

@fronzbot

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2017

yeah, I meant the referenced issue was already fixed

@fabaff fabaff referenced this pull request Aug 12, 2017

Merged

0.51 #8919

dethpickle added a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017

@home-assistant home-assistant locked and limited conversation to collaborators Dec 11, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.