Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add support to Dyson 360 Eye robot vacuum using new vacuum platform #8852
Add support to Dyson 360 Eye robot vacuum implementing the new
@azogue You did an amazing job with this platform! In less than 2 hours, I had a first fully working Dyson implementation.
Nevertheless, I had to remove a test in the
if not config[DOMAIN]: return False
Because I'm calling the setup programaticly, without adding any
I have to do that because I'm using the parent Dyson hub used also by fan/purifier. Do you see any issue by removing this test ?
Example entry for
I assume there's no I/O going on in the entity properties? Three comments. I didn't look at the tests.
Fix the two import comments and I think this is good to go.
I just updated the import orders (and also use an empty dict instead of none, it's better). Tell me if it's OK for you.
But before merging, I would like to have @azogue point of view because I updated the
Aug 6, 2017
referenced this pull request
Aug 6, 2017
added a commit
this pull request
Aug 18, 2017
Please use the forum or chat for support questions.