Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shodan sensor #8902

Merged
merged 1 commit into from Aug 10, 2017

Conversation

Projects
None yet
3 participants
@fabaff
Copy link
Member

commented Aug 9, 2017

Description:

A sensor that shows the number of results for a Shodan.io query.

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#3156

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: shodan
    api_key: !secret shodan_api
    query: 'home-assistant'

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.
@pvizeli
Copy link
Member

left a comment

I think you need not a data object in this case. Data object are usefully if you have multible sensor access to same data poll.

@pvizeli pvizeli merged commit c0663bf into dev Aug 10, 2017

5 checks passed

cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.758%
Details
hound No violations found. Woof!

@pvizeli pvizeli deleted the shodan branch Aug 10, 2017

@fabaff fabaff referenced this pull request Aug 12, 2017

Merged

0.51 #8919

dethpickle added a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017

@home-assistant home-assistant locked and limited conversation to collaborators Dec 11, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.