Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sabnzbd: do not assume discovery info is a dict #8951

Merged
merged 1 commit into from Aug 13, 2017

Conversation

Projects
None yet
6 participants
@balloob
Copy link
Member

commented Aug 13, 2017

Description:

#8634 assumed that discovery info was an empty dict when omitted. This is not the case, it's None. This patch removes that assumption.

Related issue (if applicable): fixes #8941

Would love to get feedback if this patch works @ViperRNMC / @Hellowlol

@balloob balloob added this to the 0.51.2 milestone Aug 13, 2017

@mention-bot

This comment has been minimized.

Copy link

commented Aug 13, 2017

@balloob, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @jamespcole and @Hellowlol to be potential reviewers.

@Hellowlol

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2017

All good

@balloob balloob merged commit 4b3a932 into dev Aug 13, 2017

5 checks passed

cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.771%
Details
hound No violations found. Woof!

@balloob balloob deleted the fix-sabnzbd-discovery branch Aug 13, 2017

@ViperRNMC

This comment has been minimized.

Copy link

commented Aug 13, 2017

works fine with this fix!

balloob added a commit that referenced this pull request Aug 14, 2017

@balloob balloob referenced this pull request Aug 14, 2017

Merged

0.51.2 #8980

dethpickle added a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017

@home-assistant home-assistant locked and limited conversation to collaborators Dec 11, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.