New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix call to ha_send_commands #8956

Merged
merged 1 commit into from Aug 13, 2017

Conversation

Projects
None yet
5 participants
@MartinHjelmare
Member

MartinHjelmare commented Aug 13, 2017

Description:

  • Name keyword arguments correctly according to dependency lib.
  • Only pass keyword arguments that are not None.

Related issue (if applicable):
fixes #8944

Checklist:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
Fix call to ha_send_commands
* Name keyword arguments correctly according to dependency lib.
* Only pass keyword arguments that are not None.
@mention-bot

This comment has been minimized.

mention-bot commented Aug 13, 2017

@MartinHjelmare, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @balloob and @tony2nite to be potential reviewers.

@balloobbot balloobbot added the platform label Aug 13, 2017

@MartinHjelmare MartinHjelmare added this to the 0.51.2 milestone Aug 13, 2017

@balloob balloob merged commit cbe5225 into home-assistant:dev Aug 13, 2017

4 checks passed

cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.771%
Details
hound No violations found. Woof!

balloob added a commit that referenced this pull request Aug 14, 2017

Fix call to ha_send_commands (#8956)
* Name keyword arguments correctly according to dependency lib.
* Only pass keyword arguments that are not None.

@balloob balloob referenced this pull request Aug 14, 2017

Merged

0.51.2 #8980

dethpickle added a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017

Fix call to ha_send_commands (home-assistant#8956)
* Name keyword arguments correctly according to dependency lib.
* Only pass keyword arguments that are not None.

@MartinHjelmare MartinHjelmare deleted the MartinHjelmare:fix-harmony-call branch Sep 3, 2017

@home-assistant home-assistant locked and limited conversation to collaborators Dec 11, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.