Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #8948 in pushbullet #8965

Merged
merged 2 commits into from Aug 13, 2017

Conversation

Projects
None yet
6 participants
@balloob
Copy link
Member

commented Aug 13, 2017

Description:

Check if filepath is passed in before passing it to is_allowed_path.

@tsvi

This comment has been minimized.

Copy link
Contributor

commented on dce2420 Aug 13, 2017

Thank you for fixing it. Should add some unittests next time before this gets merged.

@mention-bot

This comment has been minimized.

Copy link

commented Aug 13, 2017

@balloob, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jabesq, @tomduijf and @fabaff to be potential reviewers.

@balloob balloob merged commit 74adebc into dev Aug 13, 2017

5 checks passed

cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.776%
Details
hound No violations found. Woof!

@balloob balloob deleted the pushbullet branch Aug 13, 2017

balloob added a commit that referenced this pull request Aug 14, 2017

fix issue #8948 in pushbullet (#8965)
* fix issue #8948 in pushbullet

* pushbullet

@balloob balloob referenced this pull request Aug 14, 2017

Merged

0.51.2 #8980

dethpickle added a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017

@home-assistant home-assistant locked and limited conversation to collaborators Dec 11, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.