New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zwave power_consumption attribute #8968

Merged
merged 1 commit into from Aug 14, 2017

Conversation

Projects
None yet
6 participants
@andrey-git
Contributor

andrey-git commented Aug 13, 2017

Description:

Fix zwave power_consumption attribute that was broken by #7853
Fixes #8591

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.
@mention-bot

This comment has been minimized.

mention-bot commented Aug 13, 2017

@andrey-git, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @armills and @turbokongen to be potential reviewers.

@armills

Nice Catch! 😳

Appreciate the tests as well.

@balloob balloob added this to the 0.51.2 milestone Aug 14, 2017

@balloob balloob merged commit 23273d3 into home-assistant:dev Aug 14, 2017

4 checks passed

cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.776%
Details
hound No violations found. Woof!

balloob added a commit that referenced this pull request Aug 14, 2017

@balloob balloob referenced this pull request Aug 14, 2017

Merged

0.51.2 #8980

dethpickle added a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017

@home-assistant home-assistant locked and limited conversation to collaborators Dec 11, 2017

@andrey-git andrey-git deleted the andrey-git:zwave branch May 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.