Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix universal media_player mute #9462

Merged
merged 1 commit into from Sep 18, 2017
Merged

Fix universal media_player mute #9462

merged 1 commit into from Sep 18, 2017

Conversation

colindunn
Copy link
Contributor

@colindunn colindunn commented Sep 16, 2017

Description:

Related issue (if applicable): fixes #9461

Pull request in home-assistant.github.io with documentation (if applicable): does not affect documentation

Example entry for configuration.yaml (if applicable):

No configuration change

Checklist:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@homeassistant
Copy link
Contributor

Hi @colindunn,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@mention-bot
Copy link

@colindunn, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rmkraus, @fabaff and @pvizeli to be potential reviewers.

@colindunn
Copy link
Contributor Author

colindunn commented Sep 16, 2017

Sorry first commit here so not 100% sure of the requirements. Do I tick all of the boxes even if there are no New items involved?

Copy link
Contributor

@emlove emlove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! For posterity, the ABC function definition is here: https://github.com/home-assistant/home-assistant/blob/392588e51979ad8bc1a1f6f177354626500289cf/homeassistant/components/media_player/__init__.py#L621

You don't need to worry about the other checkboxes. They're mostly applicable to new platforms only, not small bug fixes.

@emlove emlove merged commit 15c3ea0 into home-assistant:dev Sep 18, 2017
@emlove
Copy link
Contributor

emlove commented Sep 18, 2017

Thanks for the contribution! 🎉

@balloob balloob mentioned this pull request Sep 22, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Mar 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

media_player.universal mute not working
5 participants