Display warning when debug strings is ON#4666
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an in-app warning to the Settings screens when the “Debug strings” / translation-key display mode is enabled, with a shortcut to disable it. This fits into the app’s SwiftUI Settings root view by surfacing a state that is otherwise only discoverable via the Debug settings.
Changes:
- Track the
showTranslationKeyspreference inSettingsViewstate and refresh it on appearance. - Insert a new warning
Sectionin both iOS and Mac Catalyst settings lists when debug strings are enabled. - Add an action to disable debug strings directly from the warning.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4666 +/- ##
=======================================
Coverage ? 43.98%
=======================================
Files ? 280
Lines ? 17021
Branches ? 0
=======================================
Hits ? 7487
Misses ? 9534
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes