Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hard-code upstream DNS resolvers #53

Closed
blalor opened this issue Aug 17, 2021 · 2 comments
Closed

Don't hard-code upstream DNS resolvers #53

blalor opened this issue Aug 17, 2021 · 2 comments

Comments

@blalor
Copy link

blalor commented Aug 17, 2021

Applications should not hard-code their own DNS resolvers; they should use the configuration provided by the network (via DHCP) or by the user, perhaps with an overridable default if no other option exists. This is an anti-pattern:

forward . tls://1.1.1.1 tls://1.0.0.1 {

@frenck
Copy link
Member

frenck commented Aug 17, 2021

This has been discussed in various places in the past.

#22 (comment)

The project is not changing this.

@frenck frenck closed this as completed Aug 17, 2021
@vistalba
Copy link

vistalba commented Sep 16, 2021

Would it be possible to make it configurable so that advanced users could disable this behavior?
I do not want to start a fundamental discussion, as I read a lot and I see that there are two or more views to this point.

But what is the technical reason not doing so?
I'm happy to support with that but unfortunately I do not have any experience in coding so I'm not able to raise a pull request.

Maybe some config in customize.yaml like would be possible:

dns-fallback: false

or

dns-fallback: true
dns-fallback-servers: tls://8.8.8.8

if nothing is configured in customize.yaml use the behavior like now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants