Permalink
Commits on Jan 21, 2017
  1. switch Page Navigator icon to a speech bubble

    fixes #3907
    erikdesjardins committed Jan 21, 2017
  2. Rebase and update #3267: Allow hiding children of nested comments (#3915

    )
    
    * Allow hiding children of nested comments
    
    * invert noNested option to hideNested, i18n
    
    * `nested` option to disable "hide child comments" for child comments
    
    * break up toggleComments()
    erikdesjardins committed on GitHub Jan 21, 2017
  3. Integrate updates css (#3858)

    * Merged in css hotfixes
    
    Merged code: http://pastebin.com/1793xxTZ
    
    * remove now-unnecessary `.new-comment .usertext-body` style
    
    it was used to prevent scrollbars from appearing on new comments in nightmode, but they no longer appear without it (fixed somewhere else)
    
    * integrate nightmode title colors with existing styles
    
    (most of this was already included)
    
    * migrator to remove https://cdn.redditenhancementsuite.com/updates.css
    
    * move res-neverEndingReddit-hideFloatingPauseButton to NER showPauseButton
    
    * move res-hide-tagline-frontpage to a snippet
    
    * null checks
    roshkins committed with erikdesjardins Jan 21, 2017
  4. don't run on about.reddit.com

    fixes #3914
    erikdesjardins committed Jan 21, 2017
  5. Automatically throttle/disable unused features (#3587)

    * PenaltyBox automatically throttles (and/or disables) unused features
    
    * Report multireddit navbar usage to PenaltyBox
    
    * Table.option.mapValueToObject aliases properties to row's original value
    
    Instead of copying values into a new object, to to ease updating the underlying table
    
    * Add option to disable "Tips & Tricks" menu item
    
    * Report Tips & Tricks usage to Penalty Box
    
    * Penalize delay to show multireddit navbar
    
    * fix up restips penalties
    
    * fix up penaltybox
    
    * lint fix, export const MIN/MAX
    
    * lint
    
    * lint and test table
    
    * tips description can be a bit naked
    
    * i18n penalty box
    
    * fix restips dailyTip penaltybox reference
    
    * Notify when feature suspended by penalty box, with re-enable CTA
    
    * Add flow typing to Penalty Box exports
    
    * whoops missed a backtick
    
    * flow linting penaltybox
    
    * penaltyBox.penalizedDelay explicitly accepts strings containing ints
    
    * fix flow for penalizedDelay
    
    * Move mapValueToObject to utils.object
    
    * apparently my flow is poor
    
    * Apparently deepEqual doesn't like getters
    
    * missed the import on moving mapValueToObject
    
    * mapValueToObject -> mapScalarToObject
    
    * lint
    
    * oops defineProperty
    
    * Track Profile Navigator SectionMenu with penalty box
    
    * penalty box is secondary functionality
    
    * lint
    
    * hmm what's going on with flow
    
    * update type names for mapScalarToObject
    
    * add flow return type to penalizedDelay
    
    * DRY Refactor default return value for penalizedDelay
    
    * penalizedDelay returns default value if module is disabled
    
    * Colocate sanity checks into getFeaturePenalty
    
    * Remove superfluous `featureID` abstraction around `optionKey`
    
    * Refactor pardonSuspendedFeature from suspendFeature notification button handler
    
    * javascript:void 0 -> #
    
    * type mapScalarToObject
    
    * Preemptively stop monitoring feature when disabled by penalty box
    
    If the user turns it back on from settings console, it shouldn't be turned off again automatically -- unless the user turns on monitoring again as well.
    
    * follow up on delay -> delayOption
    
    * whoops close the notification from event handler
    
    * and the new notification needs a new copy of the link
    
    * linting
    
    * MapScalarToObject uses field id for object key if available
    
    Falls back to name if not specified. Allows re-using the i18n key as option key.
    
    * Genericize notificationModuleID i18n key to moduleID
    
    Will be re-used in various modules
    
    * i18n penalty box options features field names
    
    * Simplify/standardize name to "penalty box"
    
    * Standardize to PenaltyBox, round 2
    
    * use field.key
    
    * fix en.json
    
    * tests use field.key
    
    * more penaltybox i18n and flow disambiguation
    
    * i18n RESTips menuItem
    
    * simplify Modules.isEnabled usage
    
    * cleanup, newlines
    
    * correct notifications moduleID field key
    andytuba committed with erikdesjardins Jan 21, 2017
  6. wait up to 10 seconds for comments to load

    erikdesjardins committed Jan 21, 2017
Commits on Jan 20, 2017
  1. Add reversed option for gfycat (#3879)

    * add reversed to options
    
    * add reversed property to lib/core/host.js
    WilliamChiu committed with erikdesjardins Jan 20, 2017
  2. 5.3.4

    erikdesjardins committed Jan 20, 2017
  3. 5.3.4 beta changelog

    erikdesjardins committed Jan 20, 2017
  4. Adds /r/all to the "Go Mode" navigation (#3911)

    * Adds /r/all to the "Go Mode" navigation
    
    Adds /r/all to the "Go Mode" navigation (includes changes from commit
    #3909 as well to prevent the 'A' hotkey for /r/all also firing the
    "Upvote" default hotkey.)
    
    * change default to alt-A
    corylulu committed with erikdesjardins Jan 20, 2017
  5. Change to allow reuse of hotkeys for "Go Mode" nav without double fir…

    …ing. (#3909)
    
    Non-GoMode callbacks will check for goModeActive being false before firing. This will allow the reuse of key bindings for GoMode navigation without firing both events.
    corylulu committed with erikdesjardins Jan 20, 2017
  6. Merge translations and edge ver bump (#3913)

    BenMcGarry committed with erikdesjardins Jan 20, 2017
  7. keyboardNav drawHelp: Show goMode commands properly (#3912)

    larsjohnsen committed with erikdesjardins Jan 20, 2017
  8. remove Babel destructuring and parameters transforms (#3623)

    erikdesjardins committed on GitHub Jan 20, 2017
  9. update deps (#3910)

    erikdesjardins committed on GitHub Jan 20, 2017
Commits on Jan 19, 2017
  1. Never ending comments (#3543)

    * Never ending comments
    
    - still working out how to load child comments
    
    - Finished fleshing our NEC (Never ending comments)
    
      Added a Never Ending Comments module that by default only auto-loads
      the "load more comments" link at the bottom of the page. There is an
      option to also load these links for any child comments. When this is
      enabled all links that are in the viewport are loaded, started from
      the top. This causes lower links to potentially be pushed out of the
      viewport and then not loaded until the user scrolls them down into
      view again. On the other hand, it allows for nested "load more comments"
      links to be loaded automatically as they appear.
    
    - Change from using $.filter to Array.find
      Performance improvement request since we are only
      ever using the first link we don't need to filter
      the whole list
    
    * new module syntax and i18n
    dhensche committed with erikdesjardins Jan 19, 2017
  2. commentNavigator: Fix sortType popular (#3890)

    It did not work nicely with `onScroll` since that assumes that the posts are ordered from top to bottom; `popular` sorts posts by score.
    larsjohnsen committed with erikdesjardins Jan 19, 2017
  3. Build Edge .appx (#3906)

    * build .appx for Edge with manifoldjs
    
    * upload .appx instead of .zip for Edge
    erikdesjardins committed on GitHub Jan 19, 2017
  4. Update spoiler nightmode (#3903)

    roshkins committed with erikdesjardins Jan 19, 2017
  5. Escape the lookup url during reverse image search (#3905)

    WilliamChiu committed with erikdesjardins Jan 19, 2017
Commits on Jan 18, 2017
  1. Give search a desc (#3901)

    BenMcGarry committed with erikdesjardins Jan 18, 2017
  2. Add "warning" candystripe overlay to spoiler expando buttons (#3899)

    * Refactor %expando-button-overlay from highlightNSFWButton
    
    * Add ShowImages - HighlightSpoilerButton option
    andytuba committed with erikdesjardins Jan 18, 2017
  3. Fix comment hide persistor by tracking via simply pathname (#3898)

    Fixes #3897
    
    Reddit URLs generally contain all the unique canonical bits in the pathname, and the pathname stays constant. Query parameters and subdomain shouldn't affect whether a comment is hidden.
    andytuba committed with erikdesjardins Jan 18, 2017
Commits on Jan 16, 2017
  1. remove misleading "sync" verbiage

    erikdesjardins committed on GitHub Jan 16, 2017
Commits on Jan 15, 2017
  1. Thing.{from,checkedFrom}: slightly more permissive types

    erikdesjardins committed Jan 15, 2017
Commits on Jan 14, 2017
  1. Edge Extension Manifest

    BenMcGarry committed on GitHub Jan 14, 2017
  2. testing: move Selenium host and port to environment variables for eas…

    …ier local testing (#3891)
    erikdesjardins committed on GitHub Jan 14, 2017
  3. backupAndRestore: one more serialization test

    erikdesjardins committed Jan 14, 2017
Commits on Jan 13, 2017
  1. search: fix exporting links to modules (#3889)

    erikdesjardins committed on GitHub Jan 13, 2017
  2. 5.3.3

    erikdesjardins committed Jan 13, 2017
  3. v5.3.3 beta changelog

    erikdesjardins committed Jan 13, 2017
  4. Thing: cache getSubreddit result (#3888)

    larsjohnsen committed with erikdesjardins Jan 13, 2017
Commits on Jan 12, 2017
  1. youtube: use insertParams (#3887)

    erikdesjardins committed on GitHub Jan 12, 2017
  2. 5.3.2

    erikdesjardins committed Jan 12, 2017
  3. v5.3.2 beta changelog

    erikdesjardins committed Jan 12, 2017