Name of backup on download not working - Edge #2864

Closed
BenMcGarry opened this Issue Apr 6, 2016 · 16 comments

Projects

None yet

3 participants

@BenMcGarry
Collaborator

Backup of RES settings unresponsive, restore working as intended.

Build 4.6.1 affected.

@andytuba
Collaborator
andytuba commented Apr 6, 2016

Ben reports unchanged in Win10 14316

@BenMcGarry
Collaborator

Line 30 backupAndRestore.js - Invalid Calling Object

@BenMcGarry
Collaborator

link.href = URL.createObjectURL(blob); << Invalid calling Object

@BenMcGarry
Collaborator

Appears to be a browser issue at this stage, problem with creating blobs. Issues existed in IE10+ with a similar MO to ours.

@andytuba
Collaborator

Abstracting "URL.createObjectURL / Blob" with different strategies for Edge vs Everyone Else could be a good reason to justify browsersupport-edge.js.

@erikdesjardins
Collaborator

For sure, but we should probably figure out the root cause first -- new Blob() and URL.createObjectURL() work fine in a codepen in Edge.
(for a certain definition of "fine" - it seems to ignore the download attribute and gives the file an opaque name)

@erikdesjardins
Collaborator

To add on - the function linked above can be reduced to:

function backup() {
    const blob = new Blob(['something something']);
    const link = document.createElement('a');
    link.href = URL.createObjectURL(blob);
    RESUtils.click(link);
}

and it errors in the same way.

@BenMcGarry
Collaborator
@BenMcGarry
Collaborator

In code review.

@BenMcGarry
Collaborator
BenMcGarry commented Apr 25, 2016 edited

Issue marked as fix in Edge, will test when available in build.
https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/7187326/

@BenMcGarry
Collaborator
BenMcGarry commented May 11, 2016 edited

In build 14342 backup is now functional, but it does not name the file correctly. It gives a name such as "B1BBD615-8FF5-498E-9217-3FB0AC44CB08". The downloaded file does have the settings contained. It is just the name. The download attribute is ignored.

http://codepen.io/benmcgarry/pen/xVBPKJ

Code to test it in edge.

Current issue: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/7260192/

@BenMcGarry BenMcGarry changed the title from Backup not working - Edge to Name of backup on download not working - Edge Jun 8, 2016
@BenMcGarry BenMcGarry added this to the Future milestone Jun 22, 2016
@BenMcGarry BenMcGarry self-assigned this Aug 12, 2016
@BenMcGarry
Collaborator
BenMcGarry commented Oct 13, 2016 edited

Backup File Name

We are still waiting for this bug to be serviced. The backup functionality works as intended it's just that the file is not properly named. You can follow the below to solve this if you require.

Workaround:

  1. Save the blob file.
  2. Rename it in file explorer as well as the file extension to "RES.resbackup"
@BenMcGarry
Collaborator

Issue resolved in 14971. Closed.

@BenMcGarry BenMcGarry closed this Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment