New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add post expando title if it matches the post #3561

Closed
andytuba opened this Issue Oct 26, 2016 · 4 comments

Comments

Projects
None yet
4 participants
@erikdesjardins

This comment has been minimized.

Show comment
Hide comment
@erikdesjardins

erikdesjardins Oct 26, 2016

Collaborator

Even in that example, the imgur album has a period that the title lacks...not sure how often this would work

Collaborator

erikdesjardins commented Oct 26, 2016

Even in that example, the imgur album has a period that the title lacks...not sure how often this would work

@andytuba

This comment has been minimized.

Show comment
Hide comment
@andytuba

andytuba Oct 26, 2016

Collaborator

We could do a Levinshtein distance comparison and filter if 95% match. Levenshtein distance, also useful for Filtereddit title filters.

Collaborator

andytuba commented Oct 26, 2016

We could do a Levinshtein distance comparison and filter if 95% match. Levenshtein distance, also useful for Filtereddit title filters.

@erikdesjardins

This comment has been minimized.

Show comment
Hide comment
@erikdesjardins

erikdesjardins Oct 26, 2016

Collaborator

Levenshtein distance would be super useful for filters (and fast-levenshtein is tiny and has zero dependencies), but I'm still not convinced of this use-case.

The small possibility of confusion ("why do some imgur albums not display titles?") doesn't seem worth the (also marginal) benefit of not seeing the same title twice.

Collaborator

erikdesjardins commented Oct 26, 2016

Levenshtein distance would be super useful for filters (and fast-levenshtein is tiny and has zero dependencies), but I'm still not convinced of this use-case.

The small possibility of confusion ("why do some imgur albums not display titles?") doesn't seem worth the (also marginal) benefit of not seeing the same title twice.

@vishva007

This comment has been minimized.

Show comment
Hide comment
@vishva007

vishva007 Oct 11, 2017

Hi,
Came here from hacktoberfest site. Can I look into this issue ?
Thanks

Edit: Looks like this is already being worked on by @nkoxlien .

vishva007 commented Oct 11, 2017

Hi,
Came here from hacktoberfest site. Can I look into this issue ?
Thanks

Edit: Looks like this is already being worked on by @nkoxlien .

@mc10 mc10 closed this Nov 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment