Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment Hide Persistor should key on location.pathname #3897

Closed
jewel-andraia opened this issue Jan 18, 2017 · 0 comments · Fixed by #3898
Closed

Comment Hide Persistor should key on location.pathname #3897

jewel-andraia opened this issue Jan 18, 2017 · 0 comments · Fixed by #3898
Labels
Difficulty-­­1_Easy Priority-4_Some Interest RE-Bug-Confirmed

Comments

@jewel-andraia
Copy link
Collaborator

https://www.reddit.com/r/RESissues/comments/5ome9v/bug_comment_persistor_isnt_working/

and not the full url. We can trust reddit to canonicalize the path name for us. or we can use the meta canonical tag.
jewel-andraia added a commit to jewel-andraia/Reddit-Enhancement-Suite that referenced this issue Jan 18, 2017
@jewel-andraia
Fix comment hide persistor by tracking via simply pathname
5b5d138 
Fixes honestbleeps#3897

Reddit URLs generally contain all the unique canonical bits in the pathname, and the pathname stays constant. Query parameters and subdomain shouldn't affect whether a comment is hidden.
@jewel-andraia jewel-andraia mentioned this issue Jan 18, 2017
Merged
erikdesjardins pushed a commit that referenced this issue Jan 18, 2017
@jewel-andraia @erikdesjardins
Fix comment hide persistor by tracking via simply pathname (#3898)
faaece9 
Fixes #3897

Reddit URLs generally contain all the unique canonical bits in the pathname, and the pathname stays constant. Query parameters and subdomain shouldn't affect whether a comment is hidden.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty-­­1_Easy Priority-4_Some Interest RE-Bug-Confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix comment hide persistor by tracking via simply pathname jewel-andraia/Reddit-Enhancement-Suite
1 participant
@jewel-andraia