Skip to content

Changes to the behavior of the inline image viewer #129

Closed
wants to merge 5 commits into from

2 participants

@gamefreak
Collaborator

I created a system for preserving the original link (when necessary)
without the trouble of loading entire webpages to mark history.

When necessary, the original link is saved to a property called
hrefOverride. If that is detected during expand creation then
mouseover/mouseout handlers will be attached to swap the href on demand.

This works well but it can cause the link to turn blue on mouseover.
Without marking the history this has been made nearly impossible to
prevent in the name of user privacy.

I also went back to the original link on thumbnails so there is a fallback method for all links.


On a less closely related change, galleries now display per image captions/titles.


The inline image viewer now handles TEXT types for tumblr.

I do not at this time do anything to protect from malicious HTML. (I trust tumblr enough, but this is a general purpose feature)

Consider porting the tweet viewer to run in the image viewer.

gamefreak added some commits May 2, 2012
@gamefreak gamefreak Display per-image titles/captions for galleries. 7ce3e58
@gamefreak gamefreak Keep the original link on the thumbnail. 00f8d85
@gamefreak gamefreak Attempt to preserve the original urls when following links.
I created a system for preserving the original link (when necessary)
without the trouble of loading entire webpages to mark history.

When necessary, the original link is saved to a property called
hrefOverride. If that is detected during expand creation then
mouseover/mouseout handlers will be attached to swap the href on demand.

This works well but it can cause the link to turn blue on mouseover.
Without marking the history this has been made nearly impossible to
prevent in the name of user privacy.
e5d7b75
@gamefreak gamefreak Implement TEXT expando type and tumblr handling for it
The inline image viewer now handles TEXT types for tumblr.

I do not at this time do anything to protect from malicious HTML. (I
trust tumblr enough, but this is a general purpose feature)

Consider porting the tweet viewer to run in the image viewer.
502b64a
@gamefreak gamefreak Fix a bug in snuownd's raw HTML handling. 0a56b0d
@honestbleeps
Owner
@gamefreak
Collaborator

Being able to click on the thumbnail at all is barely on my mind. I don't think I have ever even clicked on the thumbnail and I didn't know that it was a link until I saw people complaining about it not purpling their links.

The big issue here a collision of mindsets. I tend to hang around a community that is highly art/artist oriented and considers attribution to be far more important than most subs do. Since I'm used to attribution being serious business I have been treating it as such, hence why I find linking back to the original more important than coloring the browser history.

I expect that if deviantart didn't link back to the art page then you would see plenty of complaints about that too.

It's well known that you can't please everybody, but we need to try pick the way that pleases the most people. Since one of the nice things about computer programs is that they are easily reconfigurable, I say take the easy way out and pick both.

Just pick the default.

@honestbleeps
Owner
@gamefreak
Collaborator

Okay instead of tweaking things around more lets stop and think about what it does now and what it needs to do.

As of 0a56b0d:

  • L+C opens the original, doesn't mark history.
  • The main link is set to direct, switches to original for clicking/selection, does not mark.
  • The thumbnail keeps the original, doesn't mark.
  • Expando marks, provides link to original.

  • Create a function to add a URL to the queue without needing to involve the image..
  • Make L+C mark history on click.
  • Make thumbnail mark history on click.
  • Make the main link mark history on click.

Am I missing anything here?

@honestbleeps
Owner
@gamefreak
Collaborator

How about instead of queueing up URLs in the browser window, send the URLs to the background page for all browsers.

The background page could then send a foreground tab URLs one by one.

@honestbleeps
Owner
@honestbleeps
Owner

This issue seems to have been put to bed (outside of this pull request, so closing)... that was fun... I certainly underestimated some things in that little excursion.. eesh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.