Use reddit locale for i18n #3735

Merged
merged 2 commits into from Dec 6, 2016

Projects

None yet

1 participant

@erikdesjardins
Collaborator

For potential future lol/1337/pirate translations. (And to make it easier to test - e.g. just go to zh.reddit.com)

Also fixes #3648 by proxy.

Though this increases bundle size, it does not measurably impact performance (since only the user's locale is parsed/imported, the rest are just preparsed).

@erikdesjardins erikdesjardins added this to the v5.2.1 milestone Dec 6, 2016
erikdesjardins added some commits Dec 5, 2016
@erikdesjardins erikdesjardins use reddit locale for i18n ba27891
@erikdesjardins erikdesjardins basic integration tests for i18n
6214751
@erikdesjardins erikdesjardins merged commit 73f803d into honestbleeps:master Dec 6, 2016

2 of 3 checks passed

coverage/coveralls Coverage pending from Coveralls.io
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@erikdesjardins erikdesjardins deleted the erikdesjardins:reddit-language branch Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment