Reordering a table option stages options #3874

Merged
merged 4 commits into from Jan 10, 2017

Projects

None yet

1 participant

@erikdesjardins
Collaborator

Fixes #3853

@erikdesjardins erikdesjardins added this to the v5.3.x (v5.4.0) milestone Jan 10, 2017
erikdesjardins added some commits Jan 10, 2017
@erikdesjardins erikdesjardins tests for changing/staging options 69166a2
@erikdesjardins erikdesjardins use <button> instead of <input type="button"> for "+add row"
This is already used for builder options, and it makes more sense (and the main reason: it works in integration tests).
7efb905
@erikdesjardins erikdesjardins settingsConsole: reordering tables should not mutate option values di…
…rectly

...because then the stage can't tell if the option has been changed
ad89995
@erikdesjardins erikdesjardins test for dragging to reorder table options
781c2fa
@erikdesjardins erikdesjardins merged commit 586b4d2 into honestbleeps:master Jan 10, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.0003%) to 2.036%
Details
@erikdesjardins erikdesjardins deleted the erikdesjardins:table-reorder-stage branch Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment