Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add explicit support for sending string noticies #104
While it was possible to send an arbitrary notice by constructing an error manually, it wasn't possible to pass a string to the
This refactors the
@joshuap This is a little yak shaving to prepare
@joshuap I took a look at the run time of that job and it is a full 2-3 seconds longer than others. The failures were from message assertion timeouts, so I think things were running slowly. It is a shared environment, so possibly some noisy neighbors. Re-running the build should fix it.
In a related note, sorry I didn't notice this before. I don't get any notifications from Travis when the build breaks.
Thanks for trying the rebuild. I tried it locally and got the same error. It turns out that the Erlang version of the argument error is simply
I've pushed up a fix (and an explicit test). Glad the tests caught it.