New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honeybadger test mix task #107

Merged
merged 1 commit into from Nov 6, 2017

Conversation

Projects
None yet
2 participants
@minhajuddin
Member

minhajuddin commented Oct 26, 2017

Adds the ability to simulate an error using a mix task. Completes #36

@minhajuddin minhajuddin requested a review from joshuap Oct 26, 2017

@joshuap

This comment has been minimized.

Show comment
Hide comment
@joshuap

joshuap Oct 27, 2017

Member

@minhajuddin will this report a live error in the development environment by default, or do you need to add the exclude_envs config first? If the latter, is it possible to make this task always report a live error?

Member

joshuap commented Oct 27, 2017

@minhajuddin will this report a live error in the development environment by default, or do you need to add the exclude_envs config first? If the latter, is it possible to make this task always report a live error?

@minhajuddin

This comment has been minimized.

Show comment
Hide comment
@minhajuddin

minhajuddin Oct 30, 2017

Member

@joshuap Good point about the excluded_envs. I have added some code which will mute them before running the task.

Member

minhajuddin commented Oct 30, 2017

@joshuap Good point about the excluded_envs. I have added some code which will mute them before running the task.

@joshuap

This comment has been minimized.

Show comment
Hide comment
@joshuap

joshuap Oct 31, 2017

Member

Looks good, thanks! One last thing, can you add a changelog entry? Feel free to squash ans merge, the.

Member

joshuap commented Oct 31, 2017

Looks good, thanks! One last thing, can you add a changelog entry? Feel free to squash ans merge, the.

@minhajuddin

This comment has been minimized.

Show comment
Hide comment
@minhajuddin

minhajuddin Nov 5, 2017

Member

Added changelog entry and squashed the commits. Ready to be merged.

Member

minhajuddin commented Nov 5, 2017

Added changelog entry and squashed the commits. Ready to be merged.

@joshuap joshuap merged commit 1643b2a into honeybadger-io:master Nov 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@minhajuddin minhajuddin deleted the minhajuddin:honeybadger-test-mix-task branch Dec 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment