New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate component and action info when used with Phoenix #108

Merged
merged 1 commit into from Nov 7, 2017

Conversation

Projects
None yet
2 participants
@minhajuddin
Copy link
Collaborator

minhajuddin commented Oct 27, 2017

Completes #72

@minhajuddin minhajuddin requested a review from joshuap Oct 27, 2017

@minhajuddin

This comment has been minimized.

Copy link
Collaborator Author

minhajuddin commented Oct 30, 2017

One of the tests is failing because of the upgraded plug dependency in our mix lock file. We need to sort out #110 before we address this.

@minhajuddin minhajuddin force-pushed the minhajuddin:component-and-action-info branch from c6733d1 to fd8b622 Oct 31, 2017

@minhajuddin

This comment has been minimized.

Copy link
Collaborator Author

minhajuddin commented Nov 6, 2017

@joshuap this is ready to be merged after a review.

@joshuap
Copy link
Member

joshuap left a comment

@minhajuddin looking good (I haven't tested this on Crywolf yet, but I will after we merge it).

Can you add a CHANGELOG entry and rebase?

@joshuap joshuap added the in progress label Nov 6, 2017

@minhajuddin minhajuddin force-pushed the minhajuddin:component-and-action-info branch from fd8b622 to ff10b0d Nov 7, 2017

@minhajuddin

This comment has been minimized.

Copy link
Collaborator Author

minhajuddin commented Nov 7, 2017

Sorry about the changelog entry. Added now. Also rebased and squished all the commits

@minhajuddin minhajuddin force-pushed the minhajuddin:component-and-action-info branch from ff10b0d to e100ed9 Nov 7, 2017

@joshuap

This comment has been minimized.

Copy link
Member

joshuap commented Nov 7, 2017

Thanks!

@joshuap

joshuap approved these changes Nov 7, 2017

@joshuap joshuap merged commit d372db3 into honeybadger-io:master Nov 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joshuap joshuap removed the in progress label Nov 7, 2017

@minhajuddin minhajuddin deleted the minhajuddin:component-and-action-info branch Nov 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment