Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[WIP] Add installer command #11
This PR adds an installer command that is able to perform the following actions for both Laravel and Lumen:
Steps to Test or Reproduce
> git pull --prune > git checkout <branch> > vendor/bin/phpunit
@sixlive this is pretty cool! Here are a few thoughts:
If we can include the notice URL, great. Just remove that part if not.
Awesome! Thanks for the feedback!
@joshuap This is mostly good to go but I wanted to get some feedback on the success messaging.
Between the success/fail output of each task and the success message if feels like its a lot of output. I'd like to maybe find a happy medium.
We also need to better define when the success message shows. Which tasks are we willing to let fail and still show the success message?
I also took a stab at breaking up the success message based on whether the test exception was successfully sent to HB or not. Take a look at the
If it's possible for
The minimum required steps would be 1) add config (with API key), 2) send test.
What are you thinking? Shorter success message? I'm thinking that we don't really need to prompt to send the test error--we always want the test error to be sent, because that's what allows the onboarding process in our UI to continue (it waits for the test error to arrive).
I'm open to any suggestions you have about how you as a user would like the interface/output to work, though.