Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support async functions in lambdaHandler #54

Closed
joshuap opened this issue Aug 6, 2019 · 2 comments
Closed

Support async functions in lambdaHandler #54

joshuap opened this issue Aug 6, 2019 · 2 comments
Assignees
Labels

Comments

@joshuap
Copy link
Member

@joshuap joshuap commented Aug 6, 2019

We've had one report that async support may not fully work with Honeybadger.lambdaHandler. See examples here: https://docs.aws.amazon.com/lambda/latest/dg/nodejs-prog-model-handler.html

@joshuap joshuap added the help wanted label Aug 6, 2019
@DanNeish

This comment has been minimized.

Copy link

@DanNeish DanNeish commented Aug 24, 2019

@joshuap, I have tried using Honeybadger.lambdaHandler with an async lambda function and it does not work. It would be great if we could get this working.

@joshuap joshuap self-assigned this Mar 17, 2020
joshuap added a commit that referenced this issue Mar 19, 2020
Fixes #54
joshuap added a commit that referenced this issue Mar 19, 2020
Fixes #54
@joshuap joshuap closed this in #82 Mar 19, 2020
@joshuap

This comment has been minimized.

Copy link
Member Author

@joshuap joshuap commented Mar 19, 2020

As of honeybadger 1.4.0, the new Honeybadger.lambdaHandler works with async and non-async functions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.