Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: should escape any query params #300

Closed
jharley opened this issue Apr 24, 2023 · 0 comments · Fixed by #301
Closed

client: should escape any query params #300

jharley opened this issue Apr 24, 2023 · 0 comments · Fixed by #301
Labels
bug

Comments

@jharley
Copy link
Collaborator

jharley commented Apr 24, 2023

As reminded by #297, we should always url.QueryEscape any query params
@jharley jharley added the bug label Apr 24, 2023
This was referenced Apr 24, 2023
Merged
Merged
jharley added a commit that referenced this issue Apr 24, 2023
@jharley
client - escape query string when listing burn alerts for an SLO (#301)
6ac85f5 
## Which problem is this PR solving?

- Closes #300 

## Short description of the changes

As reported in #297, blindly passing HCL inputs into the query can cause
bad behaviour. This is the only other place in the codebase (after #297
is merged) which uses an unescaped query parameter.


---
- To see the specific tasks where the Asana app for GitHub is being
used, see below:
  - https://app.asana.com/0/0/1204461304887421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@jharley