Implement Redis protocol #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks a lot! |
IllIlIlIlI
reviewed
Mar 7, 2018
| func (d *redisDatum) ToString() (value string, success bool) { | ||
| switch d.DataType { | ||
| case 0x2b: | ||
| fallthrough |
There was a problem hiding this comment.
@CapacitorSet Why do you use a fallthrough here? Ty
There was a problem hiding this comment.
The parser will put a string in Content both if it receives a simple string 0x2b (line 120, it uses cmd which is of type string) or if it receives a bulk string 0x24 (line 129, str is of type string). Therefore, in both cases we use the same logic, a type assertion to string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #201, the current Redis implementation is not compatible with Redis clients - it only implements the inline commands, which (as far as I know) isn't widely used.
This PR implements the Redis protocol with a simple parser, but does not support the "inline commands". If needed, it can also be implemented.