Add event counter#312
Open
CapacitorSet wants to merge 4 commits into
Open
Conversation
c347c26 to
785db5e
Compare
785db5e to
be9bfc0
Compare
be9bfc0 to
a2090c6
Compare
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
=========================================
Coverage ? 43.57%
=========================================
Files ? 70
Lines ? 8336
Branches ? 0
=========================================
Hits ? 3632
Misses ? 4288
Partials ? 416
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #303, depends on #284.
Adds an event counter with a configurable period.
Example configuration:
This configuration groups events by the "category" key, so that eg. if one receives 10 HTTP requests in 3 seconds, the following event will be emitted:
Note that the event is fired 5 seconds after the first event, so a series of requests across 12 seconds will result in 3 separate events.
This feature opens interesting scenarios if used together with plugins (creating filters that could implement "count the number of root logins per hour", for example), which should probably be documented together with this feature. However, it's also somewhat pushing the limits of the "expressive power" granted by Honeytrap, which only allows for a data flow with a fixed order for transforms (eg. you can't use a filter after a plugin) and a fixed amount of transforms (there can only be one plugin, one group-by), an issue which might be worth looking into.